clarify resolve typo suggestion #57477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the kind of the binding that we're suggesting, and use a structured suggestion.
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'll review this tonight |
zackmdavis
approved these changes
Jan 13, 2019
| let suggestion = this.lookup_typo_candidate(path, ns, is_expected, span); | ||
| if let Some(suggestion) = suggestion { | ||
| let msg = format!( | ||
| "{} {} with a similar name exists", |
There was a problem hiding this comment.
I like this wording! (I had been unhappy with "did you mean"—the docs even say we don't want to phrase it as a question—but I wasn't sure what to replace it with.
|
📌 Commit 404ad50 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
…ckmdavis clarify resolve typo suggestion Include the kind of the binding that we're suggesting, and use a structured suggestion. Fixes rust-lang#53445.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
…ckmdavis clarify resolve typo suggestion Include the kind of the binding that we're suggesting, and use a structured suggestion. Fixes rust-lang#53445.
bors
added a commit
that referenced
this pull request
Jan 14, 2019
Rollup of 6 pull requests Successful merges: - #57232 (Parallelize and optimize parts of HIR map creation) - #57418 (MetadataOnlyCodegenBackend: run the collector only once) - #57465 (Stabilize cfg_target_vendor) - #57477 (clarify resolve typo suggestion) - #57556 (privacy: Fix private-in-public check for existential types) - #57584 (Remove the `connect_timeout_unroutable` test.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the kind of the binding that we're suggesting, and use a
structured suggestion.
Fixes #53445.